Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

Support for Guzzle request option 'http_errors'. #28

Closed
bartvanhoutte opened this issue Feb 19, 2018 · 2 comments
Closed

Support for Guzzle request option 'http_errors'. #28

bartvanhoutte opened this issue Feb 19, 2018 · 2 comments

Comments

@bartvanhoutte
Copy link

bartvanhoutte commented Feb 19, 2018 •
edited
Loading

The Guzzle request option 'http_errors' is described in the Guzzle documentation as follows:

Set to false to disable throwing exceptions on an HTTP protocol errors (i.e., 4xx and 5xx responses). Exceptions are thrown by default when HTTP protocol errors are encountered.

The HttpClientAdapter does not take this option into account, rejecting the promise even if http_errors was set to false.

See patch.txt for a possible solution.
WyriHaximus added a commit that referenced this issue Jul 23, 2018
@WyriHaximus
Support for http_errors via @bartvanhoutte from #28
bb070f0
@WyriHaximus
Copy link
Owner

Sorry it took a bit, #32 is up with this suggestion. Thank you 👍

WyriHaximus added a commit that referenced this issue Jul 23, 2018
@WyriHaximus
Merge pull request #32 from WyriHaximus/http_errors-28
188d97a 
Support for `http_errors` via @bartvanhoutte from #28
@WyriHaximus
Copy link
Owner

Just released 2.1.0 with this in it. Thanks!

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WyriHaximus @bartvanhoutte