Update ChildInterface.php #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some reactphp component are not support return type because they support >=5.4. When we use reactphp/filesystem it doesn't work. I think we don't need return type declaration Incompatiable package https://github.com/reactphp/filesystem/blob/master/src/ChildProcess/Process.php#L18
|
I use php 7.4. I need to install react/filesystem package. When i add platform config into composer.json gile it works fine now. |
|
When the platform is set to php 7.3, composer installs 1.7.0 version of this package what is too old. @WyriHaximus do you have any suggestion about how Thanks. |
WyriHaximus
reviewed
Jul 4, 2021
| public static function create(Messenger $messenger, LoopInterface $loop): void; | ||
| public static function create(Messenger $messenger, LoopInterface $loop); |
There was a problem hiding this comment.
That void return type hint isn't a bug, and intentional as well. However, if I can get the react/filesystem package to work with it removed. I'm accepting that for now and tag 4.0.0 on this package to get it unblocked. Will then do a 5.0.0 later on with additional changes I've had in mind.
WyriHaximus
approved these changes
Jul 4, 2021
|
v4 has been released and resolved the issue with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some reactphp component are not support return type because they support >=5.4. When we use reactphp/filesystem it doesn't work. I think we don't need return type declaration
Incompatiable package
https://github.com/reactphp/filesystem/blob/master/src/ChildProcess/Process.php#L18