Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove upload #194

Merged
merged 2 commits into from
Sep 26, 2022
Merged

fix: remove upload #194

merged 2 commits into from
Sep 26, 2022

Conversation

hyj1991
Copy link
Member

@hyj1991 hyj1991 commented Sep 26, 2022

CI 结束后无需再执行 upload 打包动作,减少 xprofiler 的直接依赖

Reference: https://github.com/X-Profiler/xprofiler/actions/runs/3125070023

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #194 (d904eca) into master (b4feaf4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #194   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          296       296           
=========================================
  Hits           296       296           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这上传到哪的?

@hyj1991
Copy link
Member Author

hyj1991 commented Sep 26, 2022

这上传到哪的?

最早计划用 github actions 的机器做预编译,CI 跑完后把 binary 上传到阿里云的服务器的遗留设计。

不过后来发现 actions 的机器运行时库的libcxx 版本都比较高,代码没清理,正好 urllib 升级后遇到 12.x 不兼容的问题一并清理掉了。

@hyj1991 hyj1991 merged commit 5c594a0 into X-Profiler:master Sep 26, 2022
@hyj1991 hyj1991 mentioned this pull request Oct 5, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants