Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: save Elf BuildId in corefile. #204

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Conversation

zhaolei0505
Copy link
Contributor

Save the first page of ELF (including BuildId) to let the debugger find the correct binary it used.

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #204 (cffe7c2) into master (b779aa2) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #204   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          296       296           
=========================================
  Hits           296       296           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@hyj1991 hyj1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@hyj1991 hyj1991 merged commit c574ca2 into X-Profiler:master Oct 19, 2022
This was referenced Oct 19, 2022
hyj1991 added a commit that referenced this pull request Oct 22, 2022
Commits:

  - [2f700fd] docs: update readme (#207)
  - [f4eb960] feat: support node-v19.x (#206)
  - [333593e] chore: make test more reliable (#205)
  - [c574ca2] feat: save Elf BuildId in corefile. (#204)
  - [b779aa2] feat: support finish profiling before process exit (#203)
  - [6a1701f] refactor: replace dump actions static storages with EnvironmentData (#202)
  - [7608a86] fix: ignore clean error (#200)
  - [2a6eaba] chore: static dispatch on dumpaction (#199)
  - [7d3fbb2] optimize: take action (#198)
    
PR-URL: #208
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants