refactor: consolidate dump actions #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
changed the title
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 296 296
=========================================
Hits 296 296 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hyj1991
approved these changes
Nov 1, 2022
Merged
hyj1991
added a commit
that referenced
this pull request
Dec 11, 2022
Commits: - [bfe59c1] feat: support http profiling (#215) - [85065b8] refactor: config (#214) - [ea2e7f8] fix: avoid copying constant strings (#212) - [5b157fe] fix: remove unused dump action field (#211) - [840df2a] refactor: consolidate dump actions (#210) - [289770f] refactor: js bindings (#209) PR-URL: #216
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DumpData，使用std::unique_ptr明确 owner 语义、避免需要手动释放；