Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add follow-redirect feature #469

Merged
merged 4 commits into from
Oct 15, 2023
Merged

Add follow-redirect feature #469

merged 4 commits into from
Oct 15, 2023

Conversation

smoelius
Copy link
Contributor

Fixes #468

I am new to tower, so nits are more than welcome.

I made the new layer a configurable feature, since that seemed to be the pattern.

Also, I couldn't tell whether the layers were added in a particular order. I tried to add the new layer in a place that I thought made sense.

Comment on lines 58 to 59
#[tokio::test]
async fn should_return_page_with_users() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#[tokio::test]
async fn should_return_page_with_users() {
#[tokio::test]
#[cfg_attr(not(feature = "follow-redirect"), ignore)]
async fn should_return_page_with_users() {

@XAMPPRocky XAMPPRocky merged commit 9bfba30 into XAMPPRocky:main Oct 15, 2023
10 checks passed
@XAMPPRocky
Copy link
Owner

Thank you for your PR, and congrats on your first contribution! 🎉

@smoelius smoelius deleted the follow-redirect branch October 15, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow redirects
2 participants