Skip to content

Commit

Permalink
fix: no hbs comments
Browse files Browse the repository at this point in the history
  • Loading branch information
IgnaceMaes committed Aug 21, 2024
1 parent b1a06c3 commit 9f7a537
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
4 changes: 2 additions & 2 deletions languages.json
Original file line number Diff line number Diff line change
Expand Up @@ -601,15 +601,15 @@
"GlimmerJs": {
"name": "Glimmer JS",
"line_comment": ["//"],
"multi_line_comments": [["/*", "*/"], ["<!--", "-->"], ["{{!", "}}"]],
"multi_line_comments": [["/*", "*/"], ["<!--", "-->"]],
"quotes": [["\\\"", "\\\""], ["'", "'"], ["`", "`"]],
"important_syntax": ["<template", "<style"],
"extensions": ["gjs"]
},
"GlimmerTs": {
"name": "Glimmer TS",
"line_comment": ["//"],
"multi_line_comments": [["/*", "*/"], ["<!--", "-->"], ["{{!", "}}"]],
"multi_line_comments": [["/*", "*/"], ["<!--", "-->"]],
"quotes": [["\\\"", "\\\""], ["'", "'"], ["`", "`"]],
"important_syntax": ["<template", "<style"],
"extensions": ["gts"]
Expand Down
3 changes: 1 addition & 2 deletions tests/data/glimmer_js.gjs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// 28 lines, 18 code, 7 comments, 4 blanks
// 27 lines, 18 code, 6 comments, 3 blanks
import { helper } from '@ember/component/helper';
import { modifier } from 'ember-modifier';

Expand All @@ -14,7 +14,6 @@ const setScrollPosition = modifier((element, [position]) => {

<template>
<!-- A HTML-like comment -->
{{!-- But also glimmer handlebars-like comments are valid in the template --}}
<div class="scroll-container" {{setScrollPosition @scrollPos}}>
{{#each @items as |item index|}}
Item #{{plusOne index}}: {{item}}
Expand Down
3 changes: 1 addition & 2 deletions tests/data/glimmer_ts.gts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// 19 lines, 10 code, 7 comments, 3 blanks
// 18 lines, 10 code, 6 comments, 2 blanks
import type { TemplateOnlyComponent } from '@glimmer/component';

// A single-line comment
Expand All @@ -9,7 +9,6 @@ const localVariable = 'foo';
*/
const Greet: TemplateOnlyComponent<{ name: string }> = <template>
<!-- A HTML-like comment -->
{{!-- But also glimmer handlebars-like comments are valid in the template --}}
<p>Hello, {{@name}}! {{localVariable}}</p>
<style>
p {
Expand Down

0 comments on commit 9f7a537

Please sign in to comment.