Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed language names not showing when in Light mode (light background #1048

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

Alexe1289
Copy link
Contributor

@Alexe1289 Alexe1289 commented Dec 4, 2023

Fixes #805
Changed the language names to be coloured in magenta, so it can work in Light mode (white background).
BEFORE
image

AFTER:
image

@Alexe1289 Alexe1289 marked this pull request as ready for review December 4, 2023 20:09
@Alexe1289 Alexe1289 marked this pull request as draft December 4, 2023 20:11
@XAMPPRocky
Copy link
Owner

Thank you for your PR! any reason this is a draft?

@Alexe1289 Alexe1289 marked this pull request as ready for review December 7, 2023 08:05
@Alexe1289
Copy link
Contributor Author

@XAMPPRocky I pulled this out of the draft.

@XAMPPRocky XAMPPRocky merged commit 5f755db into XAMPPRocky:master Jan 9, 2024
71 checks passed
@XAMPPRocky
Copy link
Owner

Thank you for your PR, and congrats on your first contribution! 🎉

@Alexe1289 Alexe1289 deleted the color_bug branch January 9, 2024 21:33
@Alexe1289 Alexe1289 restored the color_bug branch January 9, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parts of the output are showing in white color on white background when running in WSL2 in Alacritty
2 participants