Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Untrusted files inclusion, not guaranteed to load the right file #1344

Merged
merged 2 commits into from
Apr 30, 2023
Merged

Untrusted files inclusion, not guaranteed to load the right file #1344

merged 2 commits into from
Apr 30, 2023

Conversation

mambax7
Copy link
Collaborator

@mambax7 mambax7 commented Apr 24, 2023

Replacing relative paths in the include/require statements with absolute paths based on the current directory by using DIR
it ensures that the file paths are resolved relative to the directory of the current file, rather than relying on the include path.

geekwright
geekwright requested changes Apr 29, 2023
View reviewed changes
Copy link
Contributor

@geekwright geekwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could let the snoopy change slide by, but the other issues are show stoppers.

htdocs/install/page_configsite.php Outdated Show resolved Hide resolved
htdocs/install/page_dbconnection.php Outdated Show resolved Hide resolved
htdocs/install/page_dbsettings.php Outdated Show resolved Hide resolved
htdocs/install/page_end.php Outdated Show resolved Hide resolved
htdocs/install/page_langselect.php Outdated Show resolved Hide resolved
htdocs/install/page_start.php Outdated Show resolved Hide resolved
htdocs/install/page_tablescreate.php Outdated Show resolved Hide resolved
htdocs/install/page_tablesfill.php Outdated Show resolved Hide resolved
htdocs/install/page_theme.php Outdated Show resolved Hide resolved
htdocs/class/snoopy.php Outdated Show resolved Hide resolved
@mambax7
Copy link
Collaborator Author

mambax7 commented Apr 29, 2023

WOW!!! This is really embarrassing! And I have no idea how did it happen!
I'll fix it tonight or tomorrow.
Thank you for looking into it!

@mambax7
Copy link
Collaborator Author

mambax7 commented Apr 29, 2023

OK, it's fixed now. Once again, thanks for looking into it!

@mambax7 mambax7 requested a review from geekwright April 29, 2023 23:26
geekwright
geekwright approved these changes Apr 30, 2023
View reviewed changes
Copy link
Contributor

@geekwright geekwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geekwright geekwright merged commit fdda595 into XOOPS:master Apr 30, 2023
@geekwright geekwright mentioned this pull request May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggoffy ggoffy ggoffy approved these changes

@geekwright geekwright geekwright approved these changes

@GregMage GregMage Awaiting requested review from GregMage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mambax7 @geekwright @ggoffy