Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Greedy array_merge() #1391

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Greedy array_merge() #1391

merged 1 commit into from
Oct 31, 2023

Conversation

mambax7
Copy link
Collaborator

@mambax7 mambax7 commented Oct 27, 2023

No description provided.

ggoffy
ggoffy approved these changes Oct 29, 2023
View reviewed changes
Copy link
Contributor

@ggoffy ggoffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we are using e.g.
$merged_tags=[];
instead of
$merged_tags=array();
isn#t it anymore?

@mambax7
Copy link
Collaborator Author

mambax7 commented Oct 29, 2023

That's for compatibility with PHP 5.3.9
In the future, starting with next version, will be using:
$merged_tags=[];

@mambax7 mambax7 merged commit 39fe945 into XOOPS:master Oct 31, 2023
@mambax7 mambax7 deleted the feature/greedy_array_merge branch October 31, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggoffy ggoffy ggoffy approved these changes

@geekwright geekwright geekwright approved these changes

@GregMage GregMage Awaiting requested review from GregMage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mambax7 @geekwright @ggoffy