Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASIO latency] io_latency_ms measure does not update #2521

Closed
rrozek opened this issue May 11, 2018 · 3 comments
Closed

[ASIO latency] io_latency_ms measure does not update #2521

rrozek opened this issue May 11, 2018 · 3 comments
Assignees

Comments

@rrozek
Copy link

rrozek commented May 11, 2018

Hi!
Recently I've found that io_latency_ms reported by server_state is last read value of ApplicationImp::m_io_latency_sampler. However it looks like measure which is started on Application startup stalls after few successful measures and never updates again.
(I added log in callback to
template <class Duration> void operator() (Duration const& elapsed)
and it only executes for like... 2-5 seconds after startup

Its pretty easy to observe/reproduce but its hard for me to determine why it stalls...
for instance

  1. enable [insight] section in cfg file (or add some log in mentioned callback above, then step 2. is not necessary)
  2. add delay to network speed so it is >= 10ms
    tc qdisc add dev eth0 root netem delay 11ms
  3. start daemon
  4. when finished, remove delay rule:
    tc qdisc del dev eth0 root netem

@nbougalis
Copy link
Contributor

Hmm! Thanks for this. Will look into this.

@mellery451
Copy link
Contributor

@rrozek thanks for finding and reporting this issue. I've submitted a fix at #2542. If you'd like to verify the fix works for you, you can build from the source branch mentioned there.

@rrozek rrozek closed this as completed May 17, 2018
@rrozek
Copy link
Author

rrozek commented May 17, 2018

hi @mellery451 !
I can confirm that now measurements are running continuously.
Thank you for your fast problem identification and fix!

seelabs pushed a commit to seelabs/rippled that referenced this issue Jun 1, 2018
Fixes: XRPLF#2521

Copy ctor missed one member. Also added move since we have some rvalues
passed around here.
seelabs pushed a commit to seelabs/rippled that referenced this issue Jun 1, 2018
Fixes: XRPLF#2521

Copy ctor missed one member. Also added move since we have some rvalues
passed around here.
seelabs pushed a commit to seelabs/rippled that referenced this issue Jun 1, 2018
Fixes: XRPLF#2521

Copy ctor missed one member. Also added move since we have some rvalues
passed around here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants