Disable duplicate detector: #4438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially revert the functionality introduced with XRPLF#4195 / 5a15229 (part of 1.10.0-b1). Co-authored-by: Nik Bougalis <nikb@bougalis.net>
intelliot
requested review from
manojsdoshi,
nbougalis,
seelabs,
sgramkumar,
mtrippled and
drlongle
This was referenced Feb 25, 2023
drlongle
approved these changes
Feb 27, 2023
|
LGTM, could also remove the |
ahook
approved these changes
Feb 28, 2023
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Mar 2, 2023
* upstream/develop: Update package building scripts and images to use Conan (XRPLF#4435) Disable duplicate detector: (XRPLF#4438)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Mar 3, 2023
* upstream/develop: Set version to 1.10.0-rc4 Rename 'NFT' to 'NFToken' in DisallowIncoming flags (XRPLF#4442) Update Docker.md (XRPLF#4432) Update package building scripts and images to use Conan (XRPLF#4435) Disable duplicate detector: (XRPLF#4438)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Mar 3, 2023
* upstream/develop: Set version to 1.10.0-rc4 Rename 'NFT' to 'NFToken' in DisallowIncoming flags (XRPLF#4442) Update Docker.md (XRPLF#4432) Update package building scripts and images to use Conan (XRPLF#4435) Disable duplicate detector: (XRPLF#4438)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Mar 3, 2023
* upstream/develop: Set version to 1.10.0-rc4 Rename 'NFT' to 'NFToken' in DisallowIncoming flags (XRPLF#4442) Update Docker.md (XRPLF#4432) Update package building scripts and images to use Conan (XRPLF#4435) Disable duplicate detector: (XRPLF#4438)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Mar 3, 2023
* upstream/develop: Set version to 1.10.0-rc4 Rename 'NFT' to 'NFToken' in DisallowIncoming flags (XRPLF#4442) Update Docker.md (XRPLF#4432) Update package building scripts and images to use Conan (XRPLF#4435) Disable duplicate detector: (XRPLF#4438)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Mar 3, 2023
…ctionality * upstream/develop: Set version to 1.10.0-rc4 Rename 'NFT' to 'NFToken' in DisallowIncoming flags (XRPLF#4442) Update Docker.md (XRPLF#4432) Update package building scripts and images to use Conan (XRPLF#4435) Disable duplicate detector: (XRPLF#4438)
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Mar 3, 2023
…tpage * upstream/develop: Set version to 1.10.0-rc4 Rename 'NFT' to 'NFToken' in DisallowIncoming flags (XRPLF#4442) Update Docker.md (XRPLF#4432) Update package building scripts and images to use Conan (XRPLF#4435) Disable duplicate detector: (XRPLF#4438)
dangell7
pushed a commit
to Transia-RnD/rippled
that referenced
this pull request
Mar 5, 2023
Partially revert the functionality introduced with XRPLF#4195 / 5a15229 (part of 1.10.0-b1). Acknowledgements: Aaron Hook for responsibly disclosing this issue. Bug Bounties and Responsible Disclosures: We welcome reviews of the rippled code and urge researchers to responsibly disclose any issues they may find. To report a bug, please send a detailed report to: bugs@xrpl.org --------- Co-authored-by: Nik Bougalis <nikb@bougalis.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Partially revert the functionality introduced with #4195 / 5a15229 (part of 1.10.0-b1).
Context of Change
Supersedes #4437. This PR simply squashes the two commits in #4437. I elected to do this on a new branch/PR so that we have a clean slate to re-review and look for any other potential risks.
Alternative to this PR: #4439
Type of Change
Test Plan
@manojsdoshi @sgramkumar to prepare a test plan.
Note: This PR will be squashed to 1 commit upon merging.