Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRIVIAL] Bump codecov plugin version to version 4.5.0 #5055

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

Bronek
Copy link
Collaborator

@Bronek Bronek commented Jun 24, 2024

This version includes fix codecov/codecov-action#1471 which should end the codecov upload errors due to throttling.

High Level Overview of Change

Bump codecov-action@v4.5.0

Context of Change

Upgrade to new version of codecov-action

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

This version includes fix codecov/codecov-action#1471
which should end the codecov upload errors due to throttling.
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.3%. Comparing base (e1534a3) to head (1c3b662).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5055     +/-   ##
=========================================
- Coverage     71.3%   71.3%   -0.0%     
=========================================
  Files          796     796             
  Lines        66998   66998             
  Branches     10866   10887     +21     
=========================================
- Hits         47798   47773     -25     
- Misses       19200   19225     +25     

see 4 files with indirect coverage changes

Impacted file tree graph

Copy link
Collaborator

@intelliot intelliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not sure why github ui is not showing my approval) i see it now.

this is just a version bump. ok to merge

@Bronek Bronek added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Jun 25, 2024
@zrayn zrayn merged commit 7a1b238 into XRPLF:develop Jul 2, 2024
18 of 19 checks passed
vlntb pushed a commit to vlntb/rippled that referenced this pull request Aug 23, 2024
This version includes fix codecov/codecov-action#1471
which should end the codecov upload errors due to throttling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants