Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing lsfAMMNode flag #2674

Merged
merged 3 commits into from
Mar 28, 2024
Merged

fix: add missing lsfAMMNode flag #2674

merged 3 commits into from
Mar 28, 2024

Conversation

khancode
Copy link
Collaborator

@khancode khancode commented Mar 27, 2024 •
edited
Loading

High Level Overview of Change

Add missing lsfAMMNode flag to RippleState ledger object

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Did you update HISTORY.md?

  • Yes
  • No, this change does not impact library users

Test Plan

Current tests pass.

@khancode khancode linked an issue Mar 27, 2024 that may be closed by this pull request
Add lsfAMMNode to RippleStateFlags. #2669
Closed
mvadari
mvadari reviewed Mar 28, 2024
View reviewed changes
packages/xrpl/HISTORY.md Outdated Show resolved Hide resolved
@khancode khancode merged commit 445a05e into main Mar 28, 2024
15 checks passed
@khancode khancode deleted the missing-amm-flag branch March 28, 2024 23:03
ckeshava pushed a commit to ckeshava/xrpl.js that referenced this pull request Jun 6, 2024
@khancode @ckeshava
fix: add missing lsfAMMNode flag (XRPLF#2674)
7c2afd9 
* add missing lsfAMMNode flag

* update HISTORY

* update HISTORY
ckeshava pushed a commit to ckeshava/xrpl.js that referenced this pull request Jun 12, 2024
@khancode @ckeshava
fix: add missing lsfAMMNode flag (XRPLF#2674)
72d811f 
* add missing lsfAMMNode flag

* update HISTORY

* update HISTORY
@Jircs1 Jircs1 mentioned this pull request Sep 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvadari mvadari mvadari approved these changes

@jonathanlei jonathanlei jonathanlei approved these changes

@ckeshava ckeshava Awaiting requested review from ckeshava

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add lsfAMMNode to RippleStateFlags.
3 participants
@khancode @mvadari @jonathanlei