Rename HandBoundsMode to HandBoundsLOD for better understanding (#677)

* Rename HandBoundsMode to HandBoundsLOD * Update SDK checkout * Update submodules
XRTK · Nov 11, 2020 · 430441b · 430441b
1 parent 6c4a04b
commit 430441b
Show file tree

Hide file tree

Showing 9 changed files with 15 additions and 15 deletions.
diff --git a/Runtime/Definitions/Controllers/Hands/BaseHandControllerDataProviderProfile.cs b/Runtime/Definitions/Controllers/Hands/BaseHandControllerDataProviderProfile.cs
@@ -42,12 +42,12 @@ public abstract class BaseHandControllerDataProviderProfile : BaseMixedRealityCo
 
         [SerializeField]
         [Tooltip("Set the bounds mode to use for calculating hand bounds.")]
-        private HandBoundsMode boundsMode = HandBoundsMode.Hand;
+        private HandBoundsLOD boundsMode = HandBoundsLOD.Low;
 
         /// <summary>
         /// Set the bounds mode to use for calculating hand bounds.
         /// </summary>
-        public HandBoundsMode BoundsMode => boundsMode;
+        public HandBoundsLOD BoundsMode => boundsMode;
 
         [SerializeField]
         [Tooltip("Tracked hand poses for pose detection.")]

diff --git a/...tions/Controllers/Hands/HandBoundsMode.cs → ...itions/Controllers/Hands/HandBoundsLOD.cs b/...tions/Controllers/Hands/HandBoundsMode.cs → ...itions/Controllers/Hands/HandBoundsLOD.cs
@@ -6,17 +6,17 @@ namespace XRTK.Definitions.Controllers.Hands
     /// <summary>
     /// Available hand bounds modes.
     /// </summary>
-    public enum HandBoundsMode
+    public enum HandBoundsLOD
     {
         /// <summary>
         /// Hand bounds mode will only calculate a single bounding
         /// box encapsulating the whole hand.
         /// </summary>
-        Hand = 0,
+        Low = 0,
         /// <summary>
         /// Fingers bounds mode will create precise bounds for each finger
         /// and the palm to allow for more precise interactions.
         /// </summary>
-        Fingers
+        High
     }
 }
diff --git a/.../Controllers/Hands/HandBoundsMode.cs.meta → ...s/Controllers/Hands/HandBoundsLOD.cs.meta b/.../Controllers/Hands/HandBoundsMode.cs.meta → ...s/Controllers/Hands/HandBoundsLOD.cs.meta
diff --git a/...me/Definitions/Controllers/Simulation/Hands/SimulatedHandControllerDataProviderProfile.cs b/...me/Definitions/Controllers/Simulation/Hands/SimulatedHandControllerDataProviderProfile.cs
@@ -49,12 +49,12 @@ public class SimulatedHandControllerDataProviderProfile : SimulatedControllerDat
 
         [SerializeField]
         [Tooltip("Set the bounds mode to use for calculating hand bounds.")]
-        private HandBoundsMode boundsMode = HandBoundsMode.Hand;
+        private HandBoundsLOD boundsMode = HandBoundsLOD.Low;
 
         /// <summary>
         /// Set the bounds mode to use for calculating hand bounds.
         /// </summary>
-        public HandBoundsMode BoundsMode => boundsMode;
+        public HandBoundsLOD BoundsMode => boundsMode;
 
         [SerializeField]
         [Tooltip("Tracked hand poses for pose detection.")]

diff --git a/Runtime/Definitions/InputSystem/MixedRealityInputSystemProfile.cs b/Runtime/Definitions/InputSystem/MixedRealityInputSystemProfile.cs
@@ -128,12 +128,12 @@ public SystemType GazeProviderType
 
         [SerializeField]
         [Tooltip("Set the bounds mode to use for calculating hand bounds.")]
-        private HandBoundsMode boundsMode = HandBoundsMode.Hand;
+        private HandBoundsLOD boundsMode = HandBoundsLOD.Low;
 
         /// <summary>
         /// Set the bounds mode to use for calculating hand bounds.
         /// </summary>
-        public HandBoundsMode BoundsMode => boundsMode;
+        public HandBoundsLOD BoundsMode => boundsMode;
 
         [SerializeField]
         [Tooltip("Hand controller poses tracked.")]

diff --git a/Runtime/Interfaces/Providers/Controllers/Hands/IMixedRealityHandControllerDataProvider.cs b/Runtime/Interfaces/Providers/Controllers/Hands/IMixedRealityHandControllerDataProvider.cs
@@ -25,6 +25,6 @@ public interface IMixedRealityHandControllerDataProvider : IMixedRealityControll
         /// <summary>
         /// Gets the configured hand bounds mode to be used with hand physics.
         /// </summary>
-        HandBoundsMode BoundsMode { get; set; }
+        HandBoundsLOD BoundsMode { get; set; }
     }
 }
diff --git a/Runtime/Providers/Controllers/Hands/BaseHandControllerDataProvider.cs b/Runtime/Providers/Controllers/Hands/BaseHandControllerDataProvider.cs
@@ -58,7 +58,7 @@ protected BaseHandControllerDataProvider(string name, uint priority, BaseHandCon
         public bool UseTriggers { get; set; }
 
         /// <inheritdoc />
-        public HandBoundsMode BoundsMode { get; set; }
+        public HandBoundsLOD BoundsMode { get; set; }
 
         /// <summary>
         /// Configured <see cref="HandControllerPoseProfile"/>s for pose recognition.

diff --git a/Runtime/Providers/Controllers/Hands/MixedRealityHandController.cs b/Runtime/Providers/Controllers/Hands/MixedRealityHandController.cs
@@ -201,11 +201,11 @@ private void UpdateBounds()
         {
             var handControllerDataProvider = (IMixedRealityHandControllerDataProvider)ControllerDataProvider;
 
-            if (handControllerDataProvider.HandPhysicsEnabled && handControllerDataProvider.BoundsMode == HandBoundsMode.Hand)
+            if (handControllerDataProvider.HandPhysicsEnabled && handControllerDataProvider.BoundsMode == HandBoundsLOD.Low)
             {
                 UpdateHandBounds();
             }
-            else if (handControllerDataProvider.HandPhysicsEnabled && handControllerDataProvider.BoundsMode == HandBoundsMode.Fingers)
+            else if (handControllerDataProvider.HandPhysicsEnabled && handControllerDataProvider.BoundsMode == HandBoundsLOD.High)
             {
                 UpdatePalmBounds();
                 UpdateThumbBounds();

diff --git a/Runtime/Providers/Controllers/Simulation/Hands/SimulatedHandControllerDataProvider.cs b/Runtime/Providers/Controllers/Simulation/Hands/SimulatedHandControllerDataProvider.cs
@@ -93,7 +93,7 @@ public SimulatedHandControllerDataProvider(string name, uint priority, Simulated
         public bool UseTriggers { get; set; }
 
         /// <inheritdoc />
-        public HandBoundsMode BoundsMode { get; set; }
+        public HandBoundsLOD BoundsMode { get; set; }
 
         /// <inheritdoc />
         public HandRenderingMode RenderingMode { get; set; }