Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

If the UPM package for a platform is not installed, Several hard errors are presented in the console #330

Closed
SimonDarksideJ opened this issue Sep 16, 2019 · 2 comments
Closed

If the UPM package for a platform is not installed, Several hard errors are presented in the console #330

SimonDarksideJ opened this issue Sep 16, 2019 · 2 comments
Assignees
@SimonDarksideJ
Labels
Bug Something isn't working Resolved Resolved, no further action

Comments

@SimonDarksideJ
Copy link
Contributor

XRTK - Mixed Reality Toolkit Bug Report

Describe the bug

Most platforms require a dependant UPM package installed for it to function, e.g. Oculus (Standalone/Android), WMR and Lumin.

Currently, if the data provider is registered for a platform and the corresponding UPM package is not installed, this results in several spurious error messages saying the data provider could not be initialised.

This error should be a lot friendlier for a simple project setup issue

To Reproduce

  1. Install XRTK.Core and SDK using the Unity Package Manager
  2. Create a new Scene and use "Mixed Reality Toolkit -> Configure..."
  3. See errors

Windows Standalone - Errors about Oculus
UWP - Errors about WMR extensions
Lumin - Errors about Lumin

Expected behavior

User should receive a warning advising to check the installed UPM packages

Actual behavior

Errors and no direction for the user

Your Setup (please complete the following information)

  • Unity Version 2019.1.14
  • XRTK Version 0.1.19

Target Platform (please complete the following information)

  • WMR immersive
  • OpenVR
  • HoloLens
  • Lumin (Magic Leap)

Additional context

We don't want new users confused
@SimonDarksideJ SimonDarksideJ added the Bug Something isn't working label Sep 16, 2019
@SimonDarksideJ SimonDarksideJ self-assigned this Sep 16, 2019
SimonDarksideJ added a commit that referenced this issue Sep 16, 2019
@SimonDarksideJ
Fix for #330
bed9434 
XRTK now issues a warning if a DataProvider cannot be initialised due to the dependant UPM package that contains that provider not being loaded (DataProviderType concrete type cannot be found)
@StephenHodgson
Copy link
Contributor

I think we ought to get more specific about our platform targets.

We now have several XR platform targets that all build on Standalone

@SimonDarksideJ SimonDarksideJ mentioned this issue Sep 16, 2019
Merged
@StephenHodgson
Copy link
Contributor

Related to #247

@StephenHodgson StephenHodgson added the Resolved Resolved, no further action label Sep 18, 2019
XRTK-Build-Bot pushed a commit that referenced this issue Sep 19, 2019
@SimonDarksideJ @StephenHodgson
Added check for data provider to fix #330 (#331)
82f546d 
* Fix for #330

XRTK now issues a warning if a DataProvider cannot be initialised due to the dependant UPM package that contains that provider not being loaded (DataProviderType concrete type cannot be found)

* typo
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@SimonDarksideJ SimonDarksideJ

Labels
Bug Something isn't working Resolved Resolved, no further action
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimonDarksideJ @StephenHodgson