Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Remove current gLTF utility #800

Closed
SimonDarksideJ opened this issue Mar 11, 2021 · 3 comments · Fixed by #801
Closed

Remove current gLTF utility #800

SimonDarksideJ opened this issue Mar 11, 2021 · 3 comments · Fixed by #801

Comments

@SimonDarksideJ
Copy link
Contributor

XRTK - Mixed Reality Toolkit Feature Request

Is your feature request related to a problem? Please describe

Very simple, remove the current gLTF utilities from CORE. They cause more issues than they solve.

Additionally, because it is part of Core, it makes it impossible for an XRTK user to use an alternative.

If we still want to provide our version, then it should be extracted into its own project and updated with the latest capabilities, etc

@FejZa
Copy link
Contributor

FejZa commented Mar 11, 2021

"Additionally, because it is part of Core, it makes it impossible for an XRTK user to use an alternative."

I can see this being an issue and removing them makes sense.

You mention other issues. What are those?

@StephenHodgson
Copy link
Contributor

StephenHodgson commented Mar 11, 2021

Isn't this a duplicate?

I was gonna try to get around this pretty.

Afaik there's no real bickers besides the build window, but we could just make the gltf asset a prefab reference I suppose.

@SimonDarksideJ
Copy link
Contributor Author

SimonDarksideJ commented Mar 11, 2021

I think that issue @StephenHodgson should be moved to the separate project should we wish to continue it.

As to issues @FejZa , I have utterly failed to get gLTF models to load now and it complains about gLTF buffers being null. Granted, these are streamed gLTF's, but I already had this working, but now (when I tested again this week) it utterly fails.

But primarily because this is in core, I can't use another solution without drastic measures.

SO I suppose the question is, do we keep it and put it in its own repo or just drop it. My feeling is the former as work has gone in to this, but needs updating to the latest Khronos features and is sorely missing Animation and Streaming

StephenHodgson added a commit that referenced this issue Apr 11, 2021
* PR to extract the glTF utilities in to their own project.

Resolves #800

* Version bump

* Added string extensions for analysing file names from URI paths for glTF web loading

* Addressed feedback

* Updated Examples branch

* Updated Submodules/Examples and Submodules/WindowsMixedReality to paired glTF updates

* Reverted Examples PR and switched it to use the new glTF package
Uplifted Core version dependency for Submodules

Co-authored-by: Stephen Hodgson <hodgson.designs@gmail.com>
XRTK-Build-Bot pushed a commit that referenced this issue Apr 12, 2021
* PR to extract the glTF utilities in to their own project.

Resolves #800

* Version bump

* Added string extensions for analysing file names from URI paths for glTF web loading

* Addressed feedback

* Updated Examples branch

* Updated Submodules/Examples and Submodules/WindowsMixedReality to paired glTF updates

* Reverted Examples PR and switched it to use the new glTF package
Uplifted Core version dependency for Submodules

Co-authored-by: Stephen Hodgson <hodgson.designs@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants