This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
More robust cross platform support #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… profiles, that should be handled in the constructor of the respective data provider with a thrown exception if missing. - Moved the type null checks until after the platform check to better support false positive errors thrown when that type/assembly is probably missing because we're targeting a different platform. - updated typeRefPropertyDrawer to not throw an error if the type is missing because we're targeting a different platform.
| @@ -330,11 +328,11 @@ private static Type[] FindTypesByName(string typeName, SystemTypeAttribute filte | |||
| var types = new List<Type>(); | |||
| var filteredTypes = GetFilteredTypes(filter); | |||
|
|
|||
| for (var i = 0; i < filteredTypes.Count; i++) | |||
| foreach (var type in filteredTypes) | |||
There was a problem hiding this comment.
Why change a performant FOR loop for a more expensive ForEach?
There was a problem hiding this comment.
I'm not worried about the for each loops in editor code.
| { | ||
| string menuLabel = FormatGroupedTypeName(types[i], grouping); | ||
| var menuLabel = FormatGroupedTypeName(type, grouping); |
There was a problem hiding this comment.
Why the sudden change of explicit types to using var, we already know the format and type for each of these.
There was a problem hiding this comment.
I think it's pretty obvious that it's a string from the context.
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Apr 26, 2019
… profiles, that should be handled in the constructor of the respective data provider with a thrown exception if missing. (#120) - Moved the type null checks until after the platform check to better support false positive errors thrown when that type/assembly is probably missing because we're targeting a different platform. - updated typeRefPropertyDrawer to not throw an error if the type is missing because we're targeting a different platform.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the profile check for the spatial awareness data provider's profiles, that should be handled in the constructor of the respective data provider with a thrown exception if missing.
Moved the type null checks until after the platform check to better support false positive errors thrown when that type/assembly is probably missing because we're targeting a different platform.
updated
TypeRefPropertyDrawerto not throw an error if the type is missing because we're targeting a different platform.