This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Oculus Controller mapping update #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolving mapping issue originally identified in MRTK where near touch data was not identified and the "Pressed" call was called incorrectly. Now in the OpenVR / Generic Joystick spec, digital buttons whether as a button or axis are ratified in the Button code, single axis only axis data is handled separately.
wassx
reviewed
Sep 5, 2019
XRTK-Core/Packages/com.xrtk.core/Providers/Controllers/UnityInput/GenericJoystickController.cs
Show resolved
Hide resolved
StephenHodgson
approved these changes
Sep 5, 2019
SimonDarksideJ
added
Bug
|
Lol, I'd put this in progress to prevent merging as there was a debate on GetAxis vs GetAxisRaw on MRTK. But if changes are needed I'll just do another PR :S |
|
Sorry mate |
|
We simply need to be sure to check flags when set, especially if it's "Ready for Review" :D |
|
I think there's github hooks to make sure those labels are there before we can merge. But not sure |
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Sep 9, 2019
Resolving mapping issue originally identified in MRTK where near touch data was not identified and the "Pressed" call was called incorrectly. Now in the OpenVR / Generic Joystick spec, digital buttons whether as a button or axis are ratified in the Button code, single axis only axis data is handled separately.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Change Request
Overview
Resolving mapping issue originally identified in MRTK where near touch data was not identified and the "Pressed" call was called incorrectly.
Now in the OpenVR / Generic Joystick spec, digital buttons whether as a button or axis are ratified in the Button code, single-axis only axis data is handled separately.
Target of the change:
Is this enhancement for:
Changes:
Dependancies:
SDK change required to update default profiles.