Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Dev/poco input events #380

Merged
merged 2 commits into from
Oct 2, 2019
Merged

Dev/poco input events #380

merged 2 commits into from
Oct 2, 2019

Conversation

StephenHodgson
Copy link
Contributor

@StephenHodgson StephenHodgson commented Oct 2, 2019

XRTK - Mixed Reality Toolkit Change Request

Overview

Several requests have been made to provide a way to consume input events in POCO classes and services. This gives a way to do that, but with some warnings:

  • This should NOT be used in MonoBehaviour classes.
  • Events cannot be consumed. eventData.Used would not apply here.
  • There's no way to properly route events to subscribers in any specific order which may or may not cause race conditions in implementations that use it.

Target of the change:

Is this enhancement for:

  • Core (core framework, interfaces and definitions)

Breaking Changes:

Are there any breaking changes included in this change that would prevent or cause issue for existing projects.

  • Added Action<BaseInputEventData> OnInputEvent to the IMixedRealityInputSystem

@StephenHodgson StephenHodgson added Enhancement New feature or request Breaking Change In Progress PR currently still being developed labels Oct 2, 2019
@StephenHodgson StephenHodgson merged commit b6fe2b6 into development Oct 2, 2019
@StephenHodgson StephenHodgson deleted the dev/poco-input-events branch October 2, 2019 17:29
@StephenHodgson StephenHodgson mentioned this pull request Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Breaking Change Enhancement New feature or request In Progress PR currently still being developed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants