Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Added body tracking to solver handler #384

Merged
merged 3 commits into from
Oct 21, 2019

Conversation

StephenHodgson
Copy link
Contributor

@StephenHodgson StephenHodgson commented Oct 10, 2019

XRTK - Mixed Reality Toolkit Change Request

Overview

Added the ability to specify the body (the mixed reality playspace) as a tracked object to solve the position and rotation against. Used for body locked solvers.

Breaking Changes:

  • Renamed TrackedObjectType.MotionControllerLeft to TrackedObjectType.LeftHandOrController
  • Renamed TrackedObjectType.MotionControllerRight to TrackedObjectType.RightHandOrController

@StephenHodgson StephenHodgson added the Enhancement New feature or request label Oct 10, 2019
@StephenHodgson StephenHodgson changed the base branch from master to development October 10, 2019 20:40
Copy link
Contributor

@SimonDarksideJ SimonDarksideJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are touching the Enum, can we update it to be more generic

@StephenHodgson StephenHodgson added the Ready for review PR finished primary development, open for review label Oct 12, 2019
Copy link
Contributor

@SimonDarksideJ SimonDarksideJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine in core, however it breaks projects in the Examples. Can you also do a PR for examples to resolve the changes

@StephenHodgson
Copy link
Contributor Author

I'll be sure to do that with the next release

@StephenHodgson StephenHodgson merged commit 90ce439 into development Oct 21, 2019
@StephenHodgson StephenHodgson deleted the dev/body-tracked-solver branch October 21, 2019 13:54
@StephenHodgson
Copy link
Contributor Author

So I realized I might have made a mistake here. I didn't actually setup a BodyLock but a PlayspaceLock

When the user walks around their space the tracked objects don't update correctly with the head/body position. We'll probably need to update the rig appropriately.

XRTK-Build-Bot pushed a commit that referenced this pull request Nov 3, 2019
* Added body tracking to solver handler

* Renamed two enums to be a bit more generic
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Breaking Change Enhancement New feature or request Ready for review PR finished primary development, open for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants