This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Updated interaction event datum to better support events #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to raise properly
…ter clarify the use and intent of this flag ControlActivated is a flag to enable any input to also send a flag to specify if it's currently at the "default" state
updated documentation and fixed updated flag for when the value isn't the same as last time or if it's the default value
StephenHodgson
added
Breaking Change
Ready for review
StephenHodgson
changed the title
SimonDarksideJ
approved these changes
Dec 15, 2019
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Dec 17, 2019
* I was having some issues getting the right single axis and bool events to raise properly * updated the naming of the Changed property to ControlActivated to better clarify the use and intent of this flag ControlActivated is a flag to enable any input to also send a flag to specify if it's currently at the "default" state * forgotten to save tests after rename * updated tests updated documentation and fixed updated flag for when the value isn't the same as last time or if it's the default value * removed redundant array tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Change Request
Overview
I was having some issues getting the right single axis and bool events to raise properly, so I looked back into the interaction mapping implementation.
I setup a script to listen for trigger events and to do different things depending on the pressure used.
I noticed that the events were not coming through consistently and realized it was because the changed and updated flags were resetting each other, when in reality we want them to work independent of each other.
I renamed
ChangedtoControlActivatedto better clarify that the flag is intended to be used for bool data specifically, and that any axis could potentially use theControlActivatedflag to determine if it's state had changed.Now any axis can utilize the bool data along with the value that has been defined by the axis type.
Target of the change:
Is this enhancement for:
Breaking Changes:
ChangedtoControlActivatedand updated to docs to better define it's use and function.