This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Concrete Instanced Guid References #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…work with guid reference added guid references to all instanced classes
StephenHodgson
added
Enhancement
This was referenced Apr 28, 2020
SimonDarksideJ
suggested changes
Apr 28, 2020
XRTK-Core/Packages/com.xrtk.core/Editor/PropertyDrawers/PlatformEntryPropertyDrawer.cs
Outdated
Show resolved
Hide resolved
Mainly I'm trying to keep backwards compatibility with any references to |
They were redundant |
SimonDarksideJ
approved these changes
Apr 28, 2020
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Dec 25, 2020
* fixed controller popout window and type reference property drawer to work with guid reference added guid references to all instanced classes * PR Review Changes * removed extra semicolon * removed unneeded local var * no need for ? * removed unused members * use const value * removed unused reference * fixed NRE when attempting to render mapping profile buttons
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Change Request
Overview
Previously whenever we refactored any class we were simply serializing the
AssemblyQualifiedNameas a string, which could lead to types being unable to be found after we either rename the class or change the namespace.This change is backwards compatible to what we had previously.
The two classes to review:
SystemTypeTypeExtensionsSubmodule Changes