This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
cleaned up sdk a bit #576
Merged
cleaned up sdk a bit #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added docs and simplified interfaces
StephenHodgson
added
Breaking Change
In Progress
cleaned up headers and references
StephenHodgson
added
Ready for review
# Conflicts: # Submodules/SDK
SimonDarksideJ
approved these changes
May 9, 2020
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Dec 25, 2020
* cleaned up sdk a bit Added docs and simplified interfaces * Moved GazeProvider into core cleaned up headers and references * updated unit tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Change Request
Overview
GazeProviderfrom the SDK into Core because it's a required component for the Input System and should be shipped with the default Input System implementation.Breaking Changes:
IMixedRealityControllerVisualizer.GameObjectProxy->IMixedRealityControllerVisualizer.GameObjectIMixedRealityGazeProvide.GameObjectReference->IMixedRealityGazeProvider.GameObjectXRTK.SDK.Input.GazeProvider->XRTK.Services.InputSystem.GazeProviderSubmodule Changes
XRTK/com.xrtk.sdk#178