This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Fixed min attribute. now properly clamps min value in inspector #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added checks form near clips to prevent them from being set to zero updated all submodules
StephenHodgson
added
the
Ready for review
FejZa
approved these changes
Nov 24, 2020
|
PR looks good. Personally I don't see a scenario where profile properties need a Setter. Profile are just for in-editor configuration using the inspector. People shouldn't change profile values in code. |
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Dec 25, 2020
added checks form near clips to prevent them from being set to zero updated all submodules
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Pull Request
Overview
Changes