This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated lumin submodule checkout
Removed MeshTrianglesPerCubicMeter from Spatial Mesh Observer Profile Updated SpatialAwarenessMeshLevelOfDetail to be more consistent
This was referenced Nov 26, 2020
Blocked, needs 2019.4 LTS |
# Conflicts: # Submodules/Lumin
updated package info
# Conflicts: # Submodules/Lumin
# Conflicts: # Submodules/Examples # Submodules/Lumin # Submodules/SDK # Submodules/WindowsMixedReality
# Conflicts: # Submodules/Examples # Submodules/SDK
StephenHodgson
added
the
Ready for review
PR finished primary development, open for review
label
Dec 20, 2020
FejZa
approved these changes
Dec 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'd like to see LuminPlayerBuildTools
moved to the Lumin module but there is probably a reason for it to be in Core.
Agreed but that work is slated for 0.3 #596 |
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Dec 25, 2020
* updated lumin build tools updated lumin submodule checkout * updated lumin checkout * updated lumin checkout * Breaking change Removed MeshTrianglesPerCubicMeter from Spatial Mesh Observer Profile Updated SpatialAwarenessMeshLevelOfDetail to be more consistent * updated submodules updated package info * don't iterate over the same gameobjects twice, just clear * updated submodues * updated lumin checkout * updated submodules
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Pull Request
Overview
Breaking Changes
MeshTrianglesPerCubicMeter
from Spatial Mesh Observer ProfileSpatialAwarenessMeshLevelOfDetail
to be more consistentSubmodule changes