This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Implement Grip Pose Input action for Oculus Touch controllers #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FejZa
added
the
Ready for review
SimonDarksideJ
suggested changes
Dec 15, 2020
| private void UpdateSpatialGripData(MixedRealityInteractionMapping interactionMapping) | ||
| { | ||
| Debug.Assert(interactionMapping.AxisType == AxisType.SixDof); | ||
| interactionMapping.PoseData = CurrentControllerPose; |
There was a problem hiding this comment.
See comment on Oculus PR, needs GripPoseOffset update.
Should also look to adding the GripPoseOffset variable to the BaseController definition for use in all controllers (but only implement in those that need it for now)
FejZa
added
In Progress
SimonDarksideJ
approved these changes
Dec 15, 2020
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Dec 25, 2020
* Add grip pose to default open vr mappings * Implement raising grip pose in OTouch OpenVR * Add grip pose offset * Move grip pose offset to BaseController Co-authored-by: Stephen Hodgson <hodgson.designs@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Pull Request
Overview
Implemented grip pose input action for Oculus touch controllers. Useful when grabbing something and looking to "attach" it to the controller's / hand's grip pose.
Submodule Changes