Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Misc fixes for GUID regeneration issues #719

Merged
merged 4 commits into from
Dec 16, 2020
Merged

Misc fixes for GUID regeneration issues #719

merged 4 commits into from
Dec 16, 2020

Conversation

SimonDarksideJ
Copy link
Contributor

XRTK - Mixed Reality Toolkit Pull Request

Overview

Since the move to place the default profiles and prefabs for all the various platforms to HIDDEN folders, there isn't actually a need to regenerate the GUID's for copied assets by default.

This ensures that any references between packages are retained as the asset guids remain unchanged when copied to a project's asset folder. And since the originals are in hidden folders, there is no conflict anymore.

The facility remains should it be needed, it is simply now OFF by default

Changes

Following discussions, the following changes were agreed (following on from PR #717

Tested in a new project without issue and previous referencing issues are no longer a problem.

@SimonDarksideJ SimonDarksideJ added the Ready for review PR finished primary development, open for review label Dec 16, 2020
@SimonDarksideJ SimonDarksideJ self-assigned this Dec 16, 2020
@FejZa FejZa merged commit 0c2d228 into development Dec 16, 2020
@FejZa FejZa deleted the fix/GUIDRegen branch December 16, 2020 22:15
XRTK-Build-Bot pushed a commit that referenced this pull request Dec 25, 2020
* Initial check-in for agreed changes for asset referencing issues:

- Set GUID regeneration to FALSE by default - GUID regeneration has to be specifically called

* Reverted changes to include GUID registry

* Updated docs to refer to known potential issues

* Updated formatting and added mitigation for known issues
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ready for review PR finished primary development, open for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK references are lost when a Specific Platform has a dependency
3 participants