-
-
Notifications
You must be signed in to change notification settings - Fork 34
Conversation
XRTK-Core/Packages/com.xrtk.core/Runtime/Services/TeleportSystem/MixedRealityTeleportSystem.cs
Show resolved
Hide resolved
Overall love the work, I think it's great we have a proper profile and handlers for this now. I guess my only concern is that the default implementation cannot be packaged with the core (similar to the gaze data provider which serves a similar function as it is required for the input system to work) |
But don't most of the systems have that issue? Spatial Awareness also won't be able to do anything without SDK. |
We could have a "fallback default implementation" that kicks in if no handlers is available. As soon as one is registered in the system profile it takes over? |
Yeah but the difference with the Spatial Awareness system is that not all platforms could have data providers. I think it's more like the default gaze provider. Teleportation is essentially platform agnostic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got to try out the demos, great stuff Dino!
* Define teleport system profile * Add profile inspector definition * Register system with new profile properly * Fix teleportation * Introduce concept of teleport handler * Implement MixedRealityTeleportSystem v2 * Update submodules
XRTK - Mixed Reality Toolkit Pull Request
Overview
This PR fixes #504 and introduces some new features to the teleport system.
The core change is that the act of "teleporting" is now done by "teleportation handlers". Instead of the teleport system just moving the camera around. Using a new teleport system profile the user can configure a handler implementation to use, this opens up endless possibilities to handle teleportation.
Previously:
Now:
The PR comes with two default implementations.
InstantTeleportHandler
This is what we had so far in terms of looks and behaviour. The user selects a teleport location and instantly is moved there.
FadingTeleportHandler
This implementation will fade in / out the camera before teleporting, which leads to a more appealing and smooth teleport.
Changes
Submodule Changes