Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Teleport Mode for Teleport System #726

Merged
merged 3 commits into from
Dec 19, 2020
Merged

Teleport Mode for Teleport System #726

merged 3 commits into from
Dec 19, 2020

Conversation

FejZa
Copy link
Contributor

@FejZa FejZa commented Dec 19, 2020 •
edited
Loading

XRTK - Mixed Reality Toolkit Pull Request

Overview

This PR introduces TeleportMode to the teleport system and fixes #725

Teleport Mode has two options:

  • Default: The teleport system will instantly teleport the user to the selected location. This mode works out of the box and is the toolkit's default. This mode also works without SDK
  • Provider: In provider mode the teleport system will not teleport the user itself but instead attach a teleport provider to the camera game object. Teleport providers can be customized and implemented using the IMixedRealityTeleportProvider interface. SDK has a BaseTeleportProvider for users to get started implementing their own provider. SDK also comes with a FadingTeleportProvider as an example of fully implemented teleport provider

defaultmode
providermode

Changes

Submodule Changes

This was referenced Dec 19, 2020
Merged
Merged
@FejZa FejZa added the Ready for review PR finished primary development, open for review label Dec 19, 2020
@FejZa FejZa self-assigned this Dec 19, 2020
SimonDarksideJ
SimonDarksideJ approved these changes Dec 19, 2020
View reviewed changes
Copy link
Contributor

@SimonDarksideJ SimonDarksideJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Dino, will approve the rest too.

Could we get a separate PR to have a short "how to" guide for creating a teleport provider and explain the provider configuration list

@SimonDarksideJ SimonDarksideJ merged commit 243d699 into development Dec 19, 2020
@SimonDarksideJ SimonDarksideJ deleted the feature/teleport-mode branch December 19, 2020 17:47
@FejZa
Copy link
Contributor Author

FejZa commented Dec 19, 2020

Sure, I'll write something up.

XRTK-Build-Bot pushed a commit that referenced this pull request Dec 25, 2020
@FejZa
Teleport Mode for Teleport System (#726)
fcc4048 
* Add .vsconfig to gitignore

* Introduce teleport mode

* Clean up provider when switching back to default mode
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimonDarksideJ SimonDarksideJ SimonDarksideJ approved these changes

@StephenHodgson StephenHodgson Awaiting requested review from StephenHodgson StephenHodgson is a code owner

Assignees

@FejZa FejZa

Labels
Ready for review PR finished primary development, open for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to Start Teleport system error on install of XRTK
2 participants
@FejZa @SimonDarksideJ