This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Fix camera / head position appears way above ground for OpenVR #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FejZa
added
the
Ready for review
SimonDarksideJ
approved these changes
Dec 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Pull Request
Overview
This PR fixes the issue where with OpenVR the user would appear way above the ground when anything else than 0 was configured for the "HeadHeight" in the camera data provider profile.
The issue was in
BaseCameraDataProvider. The "ApplyHeadHeight" method runs even in editor mode. And since in edit modeXRDevice.isPresentwill always returnfalse, the artifical head height is applied to theTrackedPoseDriveron the camera. Then when the application is run, it wasn't being reset back to 0f once the device tracking kicks in.