Consolidate and clean up editor assembly

[FejZa]

XRTK - Mixed Reality Toolkit Pull Request

Overview

This is a housekeeping PR. It removes any editor only assemblies found in the Runtime/ path of the core module. Any editor specifics are now properly located in the Editor/ path / assembly of the core module.

This was a necessary step to set a proper foundation while we still can and align the package layout with the new standard.

Submodule Changes

All submodules had to be updated to adjust namespaces.

• Pipelines
• SteamVR
• Nreal
• Lenovo
• Etee
• ARCore
• SDK
• Lumin
• Oculus
• Ultraleap
• WMR
• WebXR

[FejZa]

Please hold of refviewing until I create all the submodule PRs and I also need to update a build script for this to pass.

[FejZa]

All right. Everything is ready. We need the pipelines change in first so the Unity builds can complete.

[SimonDarksideJ]

It might also be a good idea to put all the other Editor logic under the same pattern, using

XRTK.Editor.Utilities
XRTK.Editor.SDK
XRTK.Editor.Lumin

Instead of all the separate XRTK.XXX.Editor namespaces everywhre?

Thoughts @StephenHodgson / @FejZa

Wouldn't normally propose, but while we are doing this namespace reshuffle, it kinda makes sense

[FejZa]

It might also be a good idea to put all the other Editor logic under the same pattern, using

XRTK.Editor.Utilities
XRTK.Editor.SDK
XRTK.Editor.Lumin

Instead of all the separate XRTK.XXX.Editor namespaces everywhre?

Thoughts @StephenHodgson / @FejZa

Wouldn't normally propose, but while we are doing this namespace reshuffle, it kinda makes sense

What do you mean? There is no more XRTK.XXX.Editor. That's what this PR resolved. There is only XRTK.Editor.XXX and each platform module has it's own e.g. XRTK.SDK.Editor, which is fine as XRTK.SDK is the modules root namespace. We don't want XRTK.Editor.SDK as that would conflict with the root namespace of the SDK package.

[FejZa]

So the pattern is <root_namespace>.Editor everywhere now.

[SimonDarksideJ]

That's my suggestion. As with the updates currently posted, we still have this inconsistency

[FejZa]

That's my suggestion. As with the updates currently posted, we still have this inconsistency

Sorry still don't see what you mean? Can you make an example?

[SimonDarksideJ]

You changed XRTK.Utilities.Editor to XRTK.Editor.Utilities

Yet right below it you still have XRTK.Lenovo.Editor

Simples :D

[StephenHodgson]

/azp run

[azure-pipelines]

Azure Pipelines failed to run 1 pipeline(s).

[StephenHodgson]

/azp run

[azure-pipelines]

Azure Pipelines failed to run 1 pipeline(s).

[StephenHodgson]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[StephenHodgson]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[FejZa]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[StephenHodgson]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).