Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Bump Core version #755

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Bump Core version #755

merged 1 commit into from
Jan 14, 2021

Conversation

FejZa
Copy link
Contributor

@FejZa FejZa commented Jan 14, 2021

XRTK - Mixed Reality Toolkit Pull Request

Overview

Bumps the core version up to 0.2.1 due to recent breaking changes.

@FejZa FejZa added the Ready for review PR finished primary development, open for review label Jan 14, 2021
@FejZa FejZa merged commit 53a4936 into development Jan 14, 2021
@FejZa FejZa deleted the dev/core-version-bump branch January 14, 2021 21:32
@StephenHodgson
Copy link
Contributor

This wasn't done running in azure was it?

@StephenHodgson
Copy link
Contributor

How did it get merged?

@StephenHodgson
Copy link
Contributor

Oh don't mind me. I'm confused lol

@FejZa
Copy link
Contributor Author

FejZa commented Jan 15, 2021

@StephenHodgson it never ran. Just as confused as you. When I created the PR I got a message from GitHub saying something along the lines "skipped checks because branch filter (or was it path filter?) did not match".

I think a PR with only a change in the package.json doesn't seem to qualify for a build.

@StephenHodgson
Copy link
Contributor

that is correct. No worries, I was confused about which PR this was. pay no mind to my prev comments lol

XRTK-Build-Bot pushed a commit that referenced this pull request Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ready for review PR finished primary development, open for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants