This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Refactoring System Registration #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenHodgson
added
Breaking Change
In Progress
StephenHodgson
commented
Jan 24, 2021
XRTK-Core/Packages/com.xrtk.core/Runtime/Services/MixedRealityToolkit.cs
Show resolved
Hide resolved
StephenHodgson
commented
Jan 24, 2021
XRTK-Core/Packages/com.xrtk.core/Runtime/Services/MixedRealityToolkit.cs
Show resolved
Hide resolved
added a way to get the system profile added a way to check if a system is enabled
* removed the core system accessors from the xrtk service locator * updated examples * updated examples * Fixed tests
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
# Conflicts: # Submodules/Examples # Submodules/Lumin # Submodules/Oculus # Submodules/SDK # Submodules/WindowsMixedReality
fixed some componet accessors in teleport system
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
# Conflicts: # Submodules/WindowsMixedReality
This was referenced Feb 6, 2021
This was referenced Feb 6, 2021
… serializable object exceptions
StephenHodgson
added
Ready for review
added tests to make sure we cannot register a system twice added icons
FejZa
approved these changes
Feb 6, 2021
| @@ -11,13 +11,6 @@ | |||
| using XRTK.Definitions.Platforms; | |||
| using XRTK.Extensions; | |||
| using XRTK.Interfaces; | |||
| using XRTK.Interfaces.BoundarySystem; | |||
There was a problem hiding this comment.
I love this. #EndofLine
SimonDarksideJ
approved these changes
Feb 8, 2021
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Feb 11, 2021
* First pass at core system refactor * fixed compiler errors added a way to get the system profile added a way to check if a system is enabled * use interface type * better null check for extension services * fixed system registration * updated examples checkout * updated root profile inspector * removed the core system accessors from the xrtk service locator (#769) * removed the core system accessors from the xrtk service locator * updated examples * updated examples * Fixed tests * updated wmr submodule * updated core access usage * updated wmr checkout fixed some componet accessors in teleport system * updated submodules * updated packages-lock file * fixed unit tests * fixed up the root profile inspector a bit to prevent it from throwing serializable object exceptions * updated spatail awareness layer utitites * fixed some some issues with the MixedRealityToolkit.TryGetSystem<T> added tests to make sure we cannot register a system twice added icons
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Pull Request
Overview
Refactoring the core system registration for the XRTK
Also removed the core system accessors in favor of the
TryGetSystem<T>which is now cached for better perf in hot loopsChanges
Submodule changes