This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Implement utility to check for used render pipeline #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FejZa
added
the
Ready for review
FejZa
requested review from
a team and
SimonDarksideJ
and removed request for
a team
|
|
||
| switch (renderPipelineAsset.GetType().Name) | ||
| { | ||
| case urpAssetTypeName: |
There was a problem hiding this comment.
Wondering if we can use pattern matching for the types instead of using the string name
There was a problem hiding this comment.
The actual types are only available if the URP / HDRP package is installed and this check needs to work even when no render pipeline package is in use. So string is all we got.
There was a problem hiding this comment.
@FejZa do you know if those packages define symbols for the features?
There was a problem hiding this comment.
No they don't. Freya Holmér put a lot of thoughts into this and this is pretty much what she came up with in the end. It's not perfect but I don't think currently there is any better way to check this.
XRTK-Core/Packages/com.xrtk.core/Runtime/Definitions/Utilities/RenderPipeline.cs
Show resolved
Hide resolved
SimonDarksideJ
approved these changes
Jan 23, 2021
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Jan 25, 2021
* Implement utility to check for used render pipeline * Fix docs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Pull Request
Overview
Adds a small utility class to detect the render pipeline currently in use.