This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Implement grip threshold profile setting #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 23, 2021
FejZa
added
Breaking Change
Ready for review
FejZa
requested review from
a team and
SimonDarksideJ
and removed request for
a team
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…feature/hand-grip-threshold
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Ok this one is now passing checks and ready for review. |
...com.xrtk.core/Runtime/Definitions/Controllers/Hands/BaseHandControllerDataProviderProfile.cs
Outdated
Show resolved
Hide resolved
...ntime/Definitions/Controllers/Simulation/Hands/SimulatedHandControllerDataProviderProfile.cs
Outdated
Show resolved
Hide resolved
...ore/Packages/com.xrtk.core/Runtime/Definitions/InputSystem/MixedRealityInputSystemProfile.cs
Outdated
Show resolved
Hide resolved
StephenHodgson
previously approved these changes
Jan 25, 2021
StephenHodgson
approved these changes
Jan 25, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Jan 25, 2021
* Implement grip threshold profile setting * Bump version to v0.2.3 * Update submodules * Fix tooltips for grip threshold range * Update submodules Co-authored-by: Stephen Hodgson <hodgson.designs@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Pull Request
Overview
This PR addresses #665 and introduces a hand profile setting to adjust the hand grip threshold, if needed. Some users were running into issues that their grip would release too soon due to tracking imprecision. This new setting allows to lower the required grip / curl threshold of the hand for it to be considered gripping.
Changes
Breaking Changes
This is a breaking change and bumps Core up to 0.2.2.
Submodule Changes