Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Dev/rest api updates #819

Merged
merged 7 commits into from
Apr 22, 2021
Merged

Dev/rest api updates #819

merged 7 commits into from
Apr 22, 2021

Conversation

StephenHodgson
Copy link
Contributor

XRTK - Mixed Reality Toolkit Pull Request

Overview

Modernized the Rest APIs a bit.

  • Added IProgress callbacks
  • Added DownloadTextureAsync
  • Added DownladAudioClipAsync
  • Added DownloadAssetBundleAsync

@StephenHodgson StephenHodgson added the Ready for review PR finished primary development, open for review label Apr 22, 2021
Copy link
Contributor

@SimonDarksideJ SimonDarksideJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, can we get some unit tests for these updates and general rest tests, including auth

@StephenHodgson
Copy link
Contributor Author

Unit tests don't work with async afaik

@StephenHodgson
Copy link
Contributor Author

Also, what remote resources do we have to perform the tests against?

@StephenHodgson StephenHodgson merged commit 11badd2 into development Apr 22, 2021
@StephenHodgson StephenHodgson deleted the dev/rest-api-updates branch April 22, 2021 15:36
XRTK-Build-Bot pushed a commit that referenced this pull request Apr 23, 2021
* updated rest api

* fixed some formatting

* sorted some methods

* Added progress callbacks

* updated license

* sorted out all the signatures
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ready for review PR finished primary development, open for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants