Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

auto update assembly version based on package.json info #840

Merged
merged 3 commits into from
May 16, 2021
Merged

auto update assembly version based on package.json info #840

merged 3 commits into from
May 16, 2021

Conversation

StephenHodgson
Copy link
Contributor

@StephenHodgson StephenHodgson commented May 16, 2021 •
edited
Loading

XRTK - Mixed Reality Toolkit Pull Request

Overview

Provides a way to list the version of the xrtk or one of the associated packages using the assembly version name.

Example:

typeof(MixedRealityToolkit).Assembly.GetName().Version;

where the type is one of the types in the assembly you're wanting to get the version of.

foreach (var (module, version) in MixedRealityToolkit.Modules)
{
    Debug.Log($"{module}, v{version}");
}

Changes

@StephenHodgson StephenHodgson added the Ready for review PR finished primary development, open for review label May 16, 2021
FejZa
FejZa approved these changes May 16, 2021
View reviewed changes
Copy link
Contributor

@FejZa FejZa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty cool addition!

@StephenHodgson StephenHodgson merged commit b8d48e2 into development May 16, 2021
@StephenHodgson StephenHodgson deleted the dev/assembly-versioning-from-package-info branch May 16, 2021 18:52
XRTK-Build-Bot pushed a commit that referenced this pull request May 19, 2021
@StephenHodgson
auto update assembly version based on package.json info (#840)
dcd00a7 
* auto update assembly version based on package.json info

* Added Modules property to the MixedRealityToolkit to get a list of the currently loaded modules in runtime and their versions

* made preprocessor internal
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FejZa FejZa FejZa approved these changes

@SimonDarksideJ SimonDarksideJ Awaiting requested review from SimonDarksideJ

Assignees
No one assigned
Labels
Ready for review PR finished primary development, open for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Runtime APIs to get the version of each XRTK module in use
2 participants
@StephenHodgson @FejZa