This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
V160 and boundary #113
Merged
V160 and boundary #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added initial boundary implementation for Oculus
FejZa
suggested changes
May 6, 2021
...ulus/Packages/com.xrtk.oculus/Runtime/Providers/BoundarySystem/OculusBoundaryDataProvider.cs
Outdated
Show resolved
Hide resolved
|
Looks good. Just one little change for the visibility property. |
…o V160_andBoundary
...ulus/Packages/com.xrtk.oculus/Runtime/Providers/BoundarySystem/OculusBoundaryDataProvider.cs
Outdated
Show resolved
Hide resolved
...ulus/Packages/com.xrtk.oculus/Runtime/Providers/BoundarySystem/OculusBoundaryDataProvider.cs
Outdated
Show resolved
Hide resolved
...ulus/Packages/com.xrtk.oculus/Runtime/Providers/BoundarySystem/OculusBoundaryDataProvider.cs
Outdated
Show resolved
Hide resolved
...ulus/Packages/com.xrtk.oculus/Runtime/Providers/BoundarySystem/OculusBoundaryDataProvider.cs
Outdated
Show resolved
Hide resolved
...ulus/Packages/com.xrtk.oculus/Runtime/Providers/BoundarySystem/OculusBoundaryDataProvider.cs
Outdated
Show resolved
Hide resolved
...ulus/Packages/com.xrtk.oculus/Runtime/Providers/BoundarySystem/OculusBoundaryDataProvider.cs
Outdated
Show resolved
Hide resolved
StephenHodgson
previously approved these changes
May 10, 2021
StephenHodgson
approved these changes
May 10, 2021
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
May 11, 2021
* Updated Oculus API to V160 (V28) Added initial boundary implementation for Oculus * Added Boundary Implementation for Oculus * Updated Boundary Visibility to visible * Addressing visibility comment * Updated Platform services configuration to include the Oculus Boundary provider * updated build info * Updated accessors for private functions * Additional Review Comments resolved * misc cleanup * I need a little more s p a c e * removed redundant cast * removed redundant cast Co-authored-by: Stephen Hodgson <hodgson.designs@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Pull Request
Overview
Oculus API update to latest and new Boundary implementation
Changes