This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Posef extensions update & controller update #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to test this, as when I applied the same, it did not work as the HeadPose was offset out of alignment with the controllers. |
|
Yeah this wasn't trying to address the offset yet. Maybe in another pass |
… in the "driver" (API)
|
Solved the Controller height issue by replicating what Unity is doing with WMR and OpenVR (Steam) by adjusting for controller height in the driver using the eyeheight |
SimonDarksideJ
approved these changes
Nov 9, 2019
|
Do you also want to bump the version number and make a release? |
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Nov 9, 2019
* updated the posef extensions * don't ref * updated controller frame of reference * removed extra line * Updated API to replicate Unity's head height approach and altering it in the "driver" (API)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updated the
Posefextensions to be more concise and adjusted the controller's frame of reference.