This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
updated controller constructor params #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… provider active controller registry
FejZa
approved these changes
Apr 6, 2020
StephenHodgson
added a commit
that referenced
this pull request
Apr 7, 2020
* Oculus 1.44 initial check-in * Included manifest updates *Note, Force set for "Controllers and Hands" to allow for either operation / launch. Build options will be needed in the future to handle configuring this in build * Bump version to 0.1.11 * Create initial stubs for required scripts * Implement getting updated hand data * Implement confidence setting * Implement bone pose conversion * Add oculus helpers * Add root pose offset to bone pose * Create Oculus hand controller and mapping profile + inspector * Moving state update to controller * Update to recent refactors in core * Update joint pose calculations * Update child bone pose calculation * Separate hand mesh and joints update * Get hand mesh state * Commit extension * Oculus joint poses still broken * Taking work to another pc * Removed base hand data provider * Remove oculus hand controller data provider * Fix handedness string in mapping proflie * Handle case if detected controller has handedness "Both" * Use offest distance to calculate joint pose * Adjust to recent Core changes * Use proxy transforms to convert joitn poses for now * Move constructor up * Update to not depend on IMixedRealityController.UpdateController() * Reset standard oculus controller dp * Return of Oculus hand controller data provider * Implement extensions * Remove OculusHandController in favor of agnostics MRHandController * Add missing update controller call * Formatting * Estimate missing joint poses on Oculus * Fix estimated rotations * Remove obsolete code * Introduce shared hand profile configuraiton * Introduce base hand controller data provide to consume shared profile * Add label to oculus specific in inspector * Introduce HandMeshingEnabled profile setting * Introduce "Hand Tracking System Profile" * Resolve merge isssues * updated oculus hand controller data provider (#47) * updated oculus hand controller data provider * updated base controller data provider profile namespace * fixed compiler error from missing platform utility * Remove OculusHandControllerDataProvider * Introduce OculusControllerDataProviderProfile * Do not fallback to OpenVR for Oculus dp * Fusion Oculus controller data providers * Housekeeping * updated inspector * bumped minor version * Return of the OculusHandControllerDataProvider * Undo merging of Oculus data proviers * a bit of cleanup * Remove hand ray type setting * updated references (#49) * use BaseHandDataProviderProfile * Add docs for HandMeshingEnabled * Update since BaseHandControllerDataProvider now properly implements the hand interface * fixed hand data provider inspector * updated oculus hand controller profile inspector * Fix tracking confidence check * Fix profile * Fix missing cast * updated controller constructor params (#50) * updated controller constructor params * a bit more cleanup and ensured controllers we being added to the data provider active controller registry * Shorten create asset menu path (same with WMR) Co-authored-by: Simon (darkside) Jackson <darkside@zenithmoon.com> Co-authored-by: Stephen Hodgson <hodgson.designs@gmail.com> Co-authored-by: Stephen Hodgson <StephenHodgson@users.noreply.github.com> Co-authored-by: Stephen Hodgson <13334553+StephenHodgson@users.noreply.github.com>
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Dec 25, 2020
* Oculus 1.44 initial check-in * Included manifest updates *Note, Force set for "Controllers and Hands" to allow for either operation / launch. Build options will be needed in the future to handle configuring this in build * Bump version to 0.1.11 * Create initial stubs for required scripts * Implement getting updated hand data * Implement confidence setting * Implement bone pose conversion * Add oculus helpers * Add root pose offset to bone pose * Create Oculus hand controller and mapping profile + inspector * Moving state update to controller * Update to recent refactors in core * Update joint pose calculations * Update child bone pose calculation * Separate hand mesh and joints update * Get hand mesh state * Commit extension * Oculus joint poses still broken * Taking work to another pc * Removed base hand data provider * Remove oculus hand controller data provider * Fix handedness string in mapping proflie * Handle case if detected controller has handedness "Both" * Use offest distance to calculate joint pose * Adjust to recent Core changes * Use proxy transforms to convert joitn poses for now * Move constructor up * Update to not depend on IMixedRealityController.UpdateController() * Reset standard oculus controller dp * Return of Oculus hand controller data provider * Implement extensions * Remove OculusHandController in favor of agnostics MRHandController * Add missing update controller call * Formatting * Estimate missing joint poses on Oculus * Fix estimated rotations * Remove obsolete code * Introduce shared hand profile configuraiton * Introduce base hand controller data provide to consume shared profile * Add label to oculus specific in inspector * Introduce HandMeshingEnabled profile setting * Introduce "Hand Tracking System Profile" * Resolve merge isssues * updated oculus hand controller data provider (#47) * updated oculus hand controller data provider * updated base controller data provider profile namespace * fixed compiler error from missing platform utility * Remove OculusHandControllerDataProvider * Introduce OculusControllerDataProviderProfile * Do not fallback to OpenVR for Oculus dp * Fusion Oculus controller data providers * Housekeeping * updated inspector * bumped minor version * Return of the OculusHandControllerDataProvider * Undo merging of Oculus data proviers * a bit of cleanup * Remove hand ray type setting * updated references (#49) * use BaseHandDataProviderProfile * Add docs for HandMeshingEnabled * Update since BaseHandControllerDataProvider now properly implements the hand interface * fixed hand data provider inspector * updated oculus hand controller profile inspector * Fix tracking confidence check * Fix profile * Fix missing cast * updated controller constructor params (#50) * updated controller constructor params * a bit more cleanup and ensured controllers we being added to the data provider active controller registry * Shorten create asset menu path (same with WMR) Co-authored-by: Simon (darkside) Jackson <darkside@zenithmoon.com> Co-authored-by: Stephen Hodgson <hodgson.designs@gmail.com> Co-authored-by: Stephen Hodgson <StephenHodgson@users.noreply.github.com> Co-authored-by: Stephen Hodgson <13334553+StephenHodgson@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
XRTK/com.xrtk.core#501