This repository has been archived by the owner on May 13, 2022. It is now read-only.
Feature/hand tracking #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenHodgson
commented
Apr 4, 2020
...edReality/Packages/com.xrtk.wmr/Profiles/WindowsMixedRealityControllerDataProviderProfile.cs
Outdated
Show resolved
Hide resolved
StephenHodgson
commented
Apr 4, 2020
XRTK.WindowsMixedReality/Packages/com.xrtk.wmr/Utilities/WindowsMixedRealityUtilities.cs
Outdated
Show resolved
Hide resolved
* updated references * sorted references
…he hand interface
StephenHodgson
commented
Apr 5, 2020
...indowsMixedReality/Packages/com.xrtk.wmr/Controllers/WindowsMixedRealityHandDataConverter.cs
Outdated
Show resolved
Hide resolved
StephenHodgson
commented
Apr 5, 2020
XRTK.WindowsMixedReality/Packages/com.xrtk.wmr/Extensions/HandJointKindExtensions.cs
Outdated
Show resolved
Hide resolved
StephenHodgson
commented
Apr 5, 2020
XRTK.WindowsMixedReality/Packages/com.xrtk.wmr/Utilities/WindowsMixedRealityUtilities.cs
Outdated
Show resolved
Hide resolved
StephenHodgson
commented
Apr 5, 2020
XRTK.WindowsMixedReality/Packages/com.xrtk.wmr/Extensions/SystemNumericsExtensions.cs
Outdated
Show resolved
Hide resolved
|
I approve this one. I can't actually approve it cause I opened the PR lol |
StephenHodgson
commented
Apr 5, 2020
| { | ||
| base.OnEnable(); | ||
|
|
||
| handMeshingEnabled = serializedObject.FindProperty(nameof(handMeshingEnabled)); |
There was a problem hiding this comment.
I don't think these are valid anymore
* added IMixedRealityControllerDataProvider constructor param * a bit more cleanup and ensured controllers we being added to the data provider active controller registry * missed a file
# Conflicts: # XRTK.WindowsMixedReality/Packages/com.xrtk.wmr/Controllers/WindowsMixedRealityController.cs
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Dec 25, 2020
* Add WMR hand controller data provider * Fix base class * Implement hand data provider interface * Remove obsolete WMR platform hand controller data provider * Resolve merge * Create controller stub * Remove need for hand controller data provider profile * Revert WMR speciifc hand controller * Create WMR profile for data provider * Add WMR utilities for hand data conversion * Fix platform flag for WMR inspector * Implement WMR hand controller data provider * Minor refactor * Fix hand mesh observer request * Create controller and mapping profile + inspector * Fix mapping naming * Add required RefreshActiveControllers override to build * Removed base hand data provider * Remove reference to non existin base * Implement handjointkind extension * Extend wmr controller interface * Merge hand and existing controller dp and profile * Fix wmr controller dp name * Starting API upgrades * Revert some changes * Bring back WMR hand dp profile + inspector * Add WMR hc dp * Reimplement wmr hdp * Implement controller maangement * Convert to extensions * Fix source deteced raised twice * Fix WindowsMixedRealityControllerDataProvider name * Fix remove all controllers * Remove WMR hand controller * Update to MixedRealityHandController agnostic type * Request only speciif pointers * Remove redundant if clause * Move conversion to converter class similar to Oculus * Fix controller cleanup * Fix documentation copy paste error * Add missing method documentation * Introduce shared hand profile configuraiton * Introduce base hand controller data provide to consume shared profile * Introduce HandMeshingEnabled profile setting * Introduce "Hand Tracking System Profile" * Updated windows hand controller data provider (#54) * Updated windows hand controller data provider * updated base controller data provider profile namespace * Added WindowsMixedRealityHandControllerDataProviderProfile * Fusion WMR controller dp profiles * Housekeeping * bumped minor version * Restore wmr profile and inspector * Restore wmr hand profile and inspector * Restore wmr hand data provider * Shorten create asset menu path * Remove hand ray type setting * Change requests/hand tracking (#59) * updated references * sorted references * use BaseHandDataProviderProfile * use BaseHandDataProvider * Fix compiler issues * Remove .NET scripting backend support * Update since BaseHandControllerDataProvider now properly implements the hand interface * updated extensions * a bit more organization * less compiler symbols * fixed hand data provider inspector * added IMixedRealityControllerDataProvider constructor param (#61) * added IMixedRealityControllerDataProvider constructor param * a bit more cleanup and ensured controllers we being added to the data provider active controller registry * missed a file * Fixed memory issue * misc formatting Co-authored-by: Dino Fejzagic <dino.f@live.de> Co-authored-by: Stephen Hodgson <StephenHodgson@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Continued from XRTK/com.xrtk.core#216