Skip to content
This repository has been archived by the owner on May 13, 2022. It is now read-only.

Improved Windows API Checker #98

Merged
merged 3 commits into from
Sep 28, 2020

Conversation

StephenHodgson
Copy link
Contributor

XRTK - Mixed Reality Toolkit Pull Request

Overview

Removed string usages for Windows API Checker

@StephenHodgson StephenHodgson added Breaking Change Ready for review PR finished primary development, open for review labels Sep 22, 2020
@StephenHodgson
Copy link
Contributor Author

I really how how Reflectiony this feels. I don't understand why MSFT would do it this way.

FejZa
FejZa previously approved these changes Sep 22, 2020
@StephenHodgson
Copy link
Contributor Author

@FejZa before you merge this could you build and deploy this? I didn't really get a chance to make sure it actually works on device.

Copy link
Contributor

@FejZa FejZa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on device and verified to work.

@StephenHodgson StephenHodgson merged commit df7582c into development Sep 28, 2020
@StephenHodgson StephenHodgson deleted the dev/improve-api-checker-calls branch September 28, 2020 18:29
XRTK-Build-Bot pushed a commit that referenced this pull request Dec 25, 2020
* Removed string usages for Windows API Checker

* sorted usings

* updated license cause we significantly changed it
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Breaking Change Ready for review PR finished primary development, open for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants