-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add config.InstrumentAttributesGetter to optionally append attrs to latency
instrument
#334
add config.InstrumentAttributesGetter to optionally append attrs to latency
instrument
#334
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #334 +/- ##
=======================================
+ Coverage 84.1% 84.2% +0.1%
=======================================
Files 13 13
Lines 605 611 +6
=======================================
+ Hits 509 515 +6
Misses 72 72
Partials 24 24 ☔ View full report in Codecov by Sentry. |
06290a4
to
54e0d55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krantideep95, thanks for the PR.
It looks good to me overall. Please also update the CHANGELOG.md
file to reflect this new feature.
Co-authored-by: Sam Xie <sam@samxie.me>
latency
instrument
Thanks for the review @XSAM I have updated |
34e2731
to
918fd50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krantideep95 Thank you for the contribution!
This allows setting custom attributes from query context onto latency metric, like this:
resolves #333