Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dbSystem parameter from all exported functions #80

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Conversation

XSAM
Copy link
Owner

@XSAM XSAM commented Apr 5, 2022

Though db.system is a required attribute for Span, it is verbose to put it on the parameters. Users can directly use otelsql.WithAttributes option to add this attribute.

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #80 (e5c683e) into main (a91b677) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main     #80     +/-   ##
=======================================
- Coverage   80.5%   80.3%   -0.2%     
=======================================
  Files         12      12             
  Lines        678     672      -6     
=======================================
- Hits         546     540      -6     
  Misses       107     107             
  Partials      25      25             
Impacted Files Coverage Δ
config.go 90.0% <100.0%> (-1.7%) ⬇️
sql.go 79.2% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a91b677...e5c683e. Read the comment docs.

@XSAM XSAM marked this pull request as ready for review April 5, 2022 12:54
@XSAM XSAM merged commit 80d1572 into main Apr 5, 2022
@XSAM XSAM deleted the refine-functions branch April 5, 2022 12:56
@XSAM XSAM mentioned this pull request Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant