Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

新增issue模板 #3290

Merged
merged 3 commits into from
Apr 19, 2024
Merged

新增issue模板 #3290

merged 3 commits into from
Apr 19, 2024

Conversation

Fangliding
Copy link
Member

摆弄了一下 不是很会用这个 看看有啥考虑不周的

label: 重现方式
description: |-
提供重现BUG方法。
请提供可以重现问题的【最小】配置文件,包括服务端和客户端,去掉无用的出入站、规则、选项,不要在这里黏贴一大段导出的 config 文件。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个要求太高了 我也不一定能做到
我觉得模板可以写的亲和些 目的是鼓励更多人尽自己所能的参与进来

@@ -0,0 +1,30 @@
name: bug反馈
description: "提交 Xray-core 漏洞"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

问题吧 漏洞是安全方面的

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在提出问题前请先通过搜索确认是否有人提出过相同问题

label: 日志
description: |-
请先将日志等级设置为 debug.
重启 Xray-core ,再按复现方式操作,尽量减少日志中的无关部分。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

自行删减日志中可能出现的敏感信息 例如 IP UUID

@Fangliding
Copy link
Member Author

1 在看了很多issue之后 真的想要有效解决问题 确实可能得做到这个程度 这话是sb那改来的 确实说出了心声 不然就是算命半天不成最后永久放在那 我最开始的想法是宁缺毋滥 不然还是浪费时间
当然也没指望多少人真的可以把配置弄到最小 只求可以尽力删掉一些无关选项

2 我简单把bug翻译成漏洞了 这可以改

3 这个可以加 甚至考虑过写一个脱敏器 不过是TODO中的TODO了

@yuhan6665
Copy link
Member

可以理解世界 不能成为世界
那就写“尽力删掉一些无关配置”

attributes:
label: Reproduction
description: |-
Provide method to reproduce the bug.
Copy link
Collaborator

@mmmray mmmray Apr 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some simpler suggestions to users instead of minimal config:

  1. use codeblocks and <detail> properly (tell them how markdown works, it seems many don't know)
  2. are you using a panel like 3x-ui? can you try to reproduce it without panel?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in fact I considered but I don't know how to use this

@yuhan6665
Copy link
Member

行吧 还有这个"在提出问题前请先通过搜索确认是否有人提出过相同问题"

@yuhan6665 yuhan6665 merged commit 55e42c8 into XTLS:main Apr 19, 2024
@yuhan6665
Copy link
Member

感谢佬!

@Fangliding
Copy link
Member Author

最后一条
If you have a pull request can fix this. ignore everything above

@RPRX
Copy link
Member

RPRX commented Apr 20, 2024

@yuhan6665 merge 的时候忘把 title 改成英文了,麻烦改一下,建议直接 force-push 合并最近的两个 commit

Xray-core 这个项目的习惯是 commit title 用英文,下次开 PR 麻烦标题直接用英文 @Fangliding

话说一年前我也写了份 issue 模板快完工了,差点放上来,还有 REALITY README(example) 更新和半成品文章

@Fangliding
Copy link
Member Author

@yuhan6665 merge 的时候忘把 title 改成英文了,麻烦改一下,建议直接 force-push 合并最近的两个 commit

Xray-core 这个项目的习惯是 commit title 用英文,下次开 PR 麻烦标题直接用英文 @Fangliding

话说一年前我也写了份 issue 模板快完工了,差点放上来,还有 REALITY README(example) 更新和半成品文章

commit message我全都是用英文的 估计squash merge的时候手滑了用了pr标题()

@Fangliding
Copy link
Member Author

好了现在应该没问题了()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants