-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xcode9 cannot install XVim. #1074
Comments
This is unsurprising since the new source editor is said to be written from the ground up. This will likely require a decent amount of investigation since the class hierarchy that XVim is hooking in to will have changed 100%. It would be helpful if you (or anyone else) could start looking in to this so we can understand the scope of changes that need to be made! |
It was said multiple time during SOTU that the Source Editor was rewritten in Swift, so there's a chance that without the runtime dynamism of Obj-C, it might not be possible to hack Xcode to run Xvim. (or maybe i completely misunderstand the implication of the Swift rewrite; in which case disregard) |
I'm assuming (but obviously haven't checked) that much of the logic will still live in classes inheriting from NSObject. Which, depending on which Swift version their using, might mean enough of it is exposed that this will work. If they're using the new |
If anyone wants to start looking at this, I think |
I successfully hooked keyDown method of the IDEPegususSourceEditor.SourceCodeEditorView. Unfortunately there are a lot of other changes XVim must adjust to new Xcode. I'm working on it. |
By the way, does anyone know about the swift namespace -> objective-c internal naming convention? This is not mandatory for XVim but if I can easily convert these names it would be helpful. |
You can run
Here's a rundown of the "magic" characters though: https://mikeash.com/pyblog/friday-qa-2014-08-15-swift-name-mangling.html |
@keith Thanks! |
The editor in Xcode 9.0 deosn't use NSTextView. I have to migrate some NSTextView dependent code to fit to new Xcode 9.0's class "_TtC12SourceEditor16SourceEditorView". I already confirmed that I can move cursor with |
@JugglerShu Thanks a lot! |
I'm so so so so looking forward to your fixing! @JugglerShu |
@JugglerShu If there's any conversion work which I can help with, let me know. I'd rather have vim key bindings instead of 'ultra smooth scrolling' in Pegasus. |
All not used to without vim on Xcode 9 |
@antmd Thanks. Yea I think there a a lot you can help but I think creating basic structure in my side and sharing it with others, approving PR would work better than explaining everything in text message. |
Very much appreciate the work @JugglerShu. Just backed the bounty for this issue. |
FYI, beta 2 of Xcode is out. http://adcdownload.apple.com/Developer_Tools/Xcode_9_beta_2/Release_Notes_for_Xcode_9_beta_2.pdf |
Hi,any progress on this? |
Let's be patient. I'm sure @JugglerShu will let us know when he's made more progress with studying Xcode 9's new editor. Also count me in if you need a hand. |
Assign us work @JugglerShu if you need the help. We're willing and able bodies and minds. |
Same here - although I'm terrible at lower level stuff, could probably help with some aspects! |
very uncomfortable without XVim. 😂 |
Sorry for waiting you long. For Xcode9 I think I have to rewrite, re-structure the XVim. Some main component (like calculating movements) can be reused but actual event handling will be rewritten. |
@JugglerShu Thanks for your work and for updating us. I am more than happy and I think others would certainly agree, to just have features like movements, yank, paste. This is 90% of XVim to me anyway and 100% percent better than no XVim at all. |
@JugglerShu Thank you so much for all your work on this. XVim has made my life so much better the last few months! |
Any progress @JugglerShu ? Looks like people are eager to help if you can delegate some work? Looking forward to getting it to work on XCode 9 :) |
Sorry for late response. Hm... I have to find a time to work on XVim more. I only have weekends to work on it now. |
Thanks for the update Juggler, we all understand that XVim for version 9
will have limited functionality. That's ok, we'll improve it as things
progress, we have an active community ready to help. Looking forward to it.
|
The source editor in Xcode 9 is still a moving target. Beta 5 was just released and introduces code folding, etc. I'm sure that makes assigning tasks much more difficult this early on, but should become easier as Xcode 9 stabilizes. |
I wish Apple understood how important this plugin is to developers. |
@michaelnew |
@antmd Movement is really weird for me. Heres a gif: http://gph.is/2y5DiQd |
@squarefrog I haven't tried @antmd's experiment yet, but could this have something to do with line wrapping? |
@cor could be. I just tried it again, with a single view, the whole width of my screen, so that no wrapping occurs. I've observed the same behaviour but with another nuance. When using |
@JugglerShu thanks. I have merged back to master. I also added back some more functions (xvimrc, proper vim-like search, etc.). New issues should be raised here: https://github.com/XVimProject/XVim2/issues |
@squarefrog please open an issue here: https://github.com/XVimProject/XVim2/issues. A screen cast would be nice for hard-to describe issues, but isn't necessary. Thanks. |
Will do. While this is an excellent starting point, It does reinforce that there would be a huge benefit to focussing on integrating NeoVim or something similar, as the behaviour would be more consistent between XVim and Vim proper. I'm unsure of the current state-of-play with integration though, so I don't know if its still feasible. |
@basketwang, have you fixed the directory not found issue? I am still encountering, even after I renamed the folder :( ld: warning: directory not found for option '-F/Applications/Xcode.app/Contents/SharedFrameworks' ** BUILD FAILED ** The following build commands failed: |
@ShiyiZhao there are two things you can try here
|
@ShiyiZhao you need fix the XVim2.xcodeproj/project.pbxproj |
Thank you @squarefrog and @basketwang! I changed my app name to Xcode.app, updated the xcode-select and also fixed a silly bug(where I have two Applications folder, and I put it in the wrong one initially, lol). And now it works! Cheers~ |
This is awesome - thanks so much @antmd and every contributors!! |
XVim is the only Xcode plugin indispensable for me. Thank you @antmd and @JugglerSh, thank you for your work. |
I haven't had any show-stopper issues raised on XVim2, so I'm closing this issue now. Please move further feature requests and discussion to XVim2. See you there! |
Hi Thanks Zoltan |
Thank you, I highly appreciate your fast work! This makes the hassle with Xcode 9 at least somewhat comfortable. |
@zoltanbognar |
I've tried using the
|
It's working 🎉
Thanks for everyone's work on this. I'd been holding off on using Xcode 9
because it's pretty painful without Xvim. Glad to have it back.
…On Thu, Oct 12, 2017 at 9:26 AM baek-jinoo ***@***.***> wrote:
I've tried using nolink branch, but I'm still getting an error when doing
make:
The following build commands failed:
Ld build/Release/XVim2.xcplugin/
Contents/MacOS/XVim2 normal x86_64
GenerateDSYMFile build/Release/XVim2.xcplugin.dSYM build/Release/XVim2.xcplugin/Contents/MacOS/XVim2
(2 failures)
make: *** [release] Error 65
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1074 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAaVqXZxMzEc2ls6_tZRPd1EYFZAHhFYks5srU7BgaJpZM4Nxbkg>
.
|
Big Thank You - nolink branch is working now for me - I love it - thank You thank You - now I can swithc to xcode 9 |
It didn't work for me because I changed the name of |
I'm exciting. |
XVim2 works 🎉 |
Cheers! |
thank you @antmd @JugglerShu doing god's work over here. I couldn't switch over to xcode 9 even if my work forced me to do it lmao. ended up having to code in xcode 8 then submitted with xcode 9 as a work around. |
I'm up and running on XVim, incredible. Thanks to everyone who contributed code and bounty source money to make this happen. Great to see there are others who are as committed as I am to the Vim Experience. |
I installed Xcode9 beta today and tried to install XVim.
But Xvim shows build error written above.
DVTTextSidebarViewHook.h: 11
Plz fix it.
Thx for your reading this issue.
The text was updated successfully, but these errors were encountered: