Fix Shift-O on the last line of the file #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where, when the start of the line is the last character of the file, there an off by 1 error that would cause shift-o not to work. `characterAtIndex` expects and index within the bounds of this string, the passed character index was previously the length of the string. This fixes #675
|
Ping |
|
Sorry I have been in hospital and couldn't reply. I'll see the PR and take some actions. |
JugglerShu
added a commit
that referenced
this pull request
Feb 10, 2015
Fix Shift-O on the last line of the file
This was referenced Oct 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where, when the start of the line is the last
character of the file, there an off by 1 error that would cause shift-o
not to work.
characterAtIndexexpects and index within the bounds ofthis string, the passed character index was previously the length of the
string.
This fixes #675