Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode8: fix relative line numbers #980

Merged
merged 5 commits into from
Oct 7, 2016
Merged

Conversation

antmd
Copy link
Contributor

@antmd antmd commented Aug 18, 2016

Hi,

I fixed relative number for Xvim on Xcode8. I think it should be backward compatible with Xcode7, but I can't test as I don't have Xcode7.

This is a pull request against 'master', because that's the only branch that contains the updates for Xcode8 at the moment.

Feel free to reject until it is decided what to do with the Xcode8 changes. I can see the alternatives:

a) rolling Xcode8 changes into develop, so I can put my changes there
b) creating new 'xcode8' branch from before first Xcode8 change on master, then reverting the changes on master

I favour b) : it won't cause 'branch explosion', as the rate of commits is quite small at the moment, and as Xcode8 now makes things a lot harder for plugin authors, it might be worth keeping 'master' 'clean' until we have a better story for continued development.

Best Regards
--Anthony

@Goles
Copy link
Member

Goles commented Oct 5, 2016

@JugglerShu This one seems rather important and looks good. What are your thoughts?

@JugglerShu
Copy link
Contributor

Sorry I haven't checked this yet.
But one thing at least to say. Why does it have a header file in the root directory of the XVim?

@Goles
Copy link
Member

Goles commented Oct 5, 2016

looking at that too @JugglerShu , to be honest, it's not evident to me. @antmd thoughts on that?

@antmd
Copy link
Contributor Author

antmd commented Oct 5, 2016

Yes, @Goles @JugglerShu that file was a mistake. I've deleted it. Looking at my change critically, I wonder if it would have been better to use a runtime check for Xcode8/7 instead of a compile-time check. The problem with a compile-time check is that if we distribute pre-built packages, then we'd need two different packages...on the positive side, I'm not a fan of lots of 'respondsToSelector:' calls...but I can understand why they might be more practical. So, I can re-work this to use run-time checks, if necessary. Best, --Anthony

@JugglerShu JugglerShu merged commit 084af63 into XVimProject:master Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants