Use webpack5 syntax to include woff2 in bundle and remove url-loader #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at's no longer in use
|
@dotnet-policy-service agree |
|
@sungam3r do you know how I can ping the maintainer to look at this PR? Thanks. |
* Bump from 1.10.4 to 1.12.0
|
I've tested this solution locally and it resolved a range of issues that have been floated around v8.x of the health check UIs.
LGTM |
This was referenced Jun 20, 2024
Jamie-Clayton
approved these changes
Jun 20, 2024
rob-baldwin
approved these changes
Jun 21, 2024
…_Vulnerable_Nuget fix: Azure Identity CVE-2024-35255
|
@unaizorrilla - Would you have time to review some of these PR's, please? Gracias |
|
@Alirexaa this would be a good inclusion in v8.1 |
--------- Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
iploooox
approved these changes
Jul 3, 2024
|
@markmonster Any idea when this can be released? |
I have no idea at all. This is managed by the maintainers of this project. I hope it can be released soon. |
…at's no longer in use
…er/AspNetCore.Diagnostics.HealthChecks into bug/2130-icons-missing
6 tasks
|
This was released by 2024-08-29 with AspNetCore.HealthChecks.UI version 8.0.2 (not by me, im just a user of the package :) ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR will fix the #2130 . The real developer of this PR is actually #2133 but this somehow got stuck in merging. That's why I tried to get the administrative process going after almost 5 months. The credits should go to schulz3000.
Which issue(s) this PR fixes: #2130
Special notes for your reviewer:
Use webpack5 syntax to include woff2 in bundle and remove url-loader that's no longer in use.
Does this PR introduce a user-facing change?:
It will reinstate the icons that got lost with a previous change.
Please make sure you've completed the relevant tasks for this PR, out of the following list: